Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98872: Fix a possible resource leak in Python 3.11.0 #99047

Merged
merged 5 commits into from
Nov 24, 2022
Merged

gh-98872: Fix a possible resource leak in Python 3.11.0 #99047

merged 5 commits into from
Nov 24, 2022

Conversation

SQLPATCH
Copy link
Contributor

@SQLPATCH SQLPATCH commented Nov 3, 2022 •
edited by miss-islington
Loading

Issue: #98872

Automerge-Triggered-By: GH:kumaraditya303

@bedevere-bot bedevere-bot mentioned this pull request Nov 3, 2022
Closed
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Nov 3, 2022 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

kumaraditya303
kumaraditya303 approved these changes Nov 6, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the this isn't a security issue as the file will be closed anyways by the kernel and this is only used when building CPython so the news entry should be moved to Build section.

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.11 only security fixes labels Nov 6, 2022
@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 4e5f2db into python:main Nov 24, 2022
@miss-islington
Copy link
Contributor

Thanks @SQLPATCH for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99748 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2022
@SQLPATCH @miss-islington
pythongh-98872: Fix a possible resource leak in Python 3.11.0 (python…
3a5bd2d 
…GH-99047)

Issue: pythonGH-98872
(cherry picked from commit 4e5f2db)

Co-authored-by: SQLPATCH <95843853+SQLPATCH@users.noreply.github.com>
Automerge-Triggered-By: GH:kumaraditya303
miss-islington added a commit that referenced this pull request Nov 24, 2022
@miss-islington @SQLPATCH
gh-98872: Fix a possible resource leak in Python 3.11.0 (GH-99047)
4255a9f 
Issue: GH-98872
(cherry picked from commit 4e5f2db)

Co-authored-by: SQLPATCH <95843853+SQLPATCH@users.noreply.github.com>
Automerge-Triggered-By: GH:kumaraditya303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SQLPATCH @bedevere-bot @miss-islington @erlend-aasland @kumaraditya303